Fix E4 model perspectives being converted to orphan local copies#3972
Merged
akurtakov merged 1 commit intoeclipse-platform:masterfrom May 7, 2026
Merged
Fix E4 model perspectives being converted to orphan local copies#3972akurtakov merged 1 commit intoeclipse-platform:masterfrom
akurtakov merged 1 commit intoeclipse-platform:masterfrom
Conversation
Member
Author
|
Problem can be seen with IWorkbenchPageTeset.testE4PerspectiveNotConvertedToLocalCopy and WorkbenchPage changes are reverted. |
merks
approved these changes
May 6, 2026
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
Just one typo and one question about the test cleanup. Otherwise it looks fine.
E4 model perspectives are being made into local copies as it counted them as "orphan" with log like: ``` !ENTRY org.eclipse.ui 1 1 2026-05-06 12:00:28.236 !MESSAGE Perspective with name 'Some name' and id 'org.some.id' has been made into a local copy ``` Perspectives with contributorURI in fragments are fully defined and not orphan thus add them directly without going through orphan and local copy.
Contributor
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E4 model perspectives are being made into local copies as it counted them as "orphan" with log like:
Perspectives with contributorURI in fragments are fully defined and not orphan thus add them directly without going through orphan and local copy.